Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(tests): implement initial PR review comments #1118

Merged
merged 7 commits into from
Nov 15, 2023
Merged

style(tests): implement initial PR review comments #1118

merged 7 commits into from
Nov 15, 2023

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Nov 14, 2023

No description provided.

@hejtful hejtful requested a review from kulla November 14, 2023 10:42
kulla
kulla reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@kulla kulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hejtful I went through the PR and fixed the current type errors. In the comments you can see what I have done.

__tests__/__utils__/handlers.ts Show resolved Hide resolved
__tests__/__utils__/handlers.ts Show resolved Hide resolved
__tests__/schema/user/delete-bots.ts Show resolved Hide resolved
@kulla
Copy link
Member

kulla commented Nov 14, 2023

@hejtful After reading https://mswjs.io/docs/api/http-response I reintroduced HttpResponse again. Seems to be the best practice for now...

kulla
kulla approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@kulla kulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hejtful Can be merged after tests are fixed

@hejtful
Copy link
Contributor Author

hejtful commented Nov 15, 2023

Tests were failing because the merging of expectedPayloads[i] and actualBody.payload is actually necessary, expectedPayloads are Partials.

@hejtful hejtful marked this pull request as ready for review November 15, 2023 12:12
@hejtful hejtful added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit b6230ad Nov 15, 2023
10 checks passed
@hejtful hejtful deleted the chore/msw-upgrade-follow-ups branch November 15, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulla kulla kulla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hejtful @kulla