Allow multiple messages (context window) to be passed #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulla
requested changes
Nov 30, 2023
| @@ -40,28 +44,23 @@ export async function executePrompt(args: { | |||
|
|
|||
| const response = await openai.chat.completions.create({ | |||
| model: 'gpt-4-1106-preview', | |||
| messages: [ | |||
| { | |||
| role: 'user', | |||
There was a problem hiding this comment.
Is this the name for the session?
There was a problem hiding this comment.
Which one?
The model is gpt-4-turbo. The session and context window will get built by the client so the session name is implict
There was a problem hiding this comment.
Another question: What is the purpose of role in the API?
There was a problem hiding this comment.
To define system prompts vs. user prompts.
Co-authored-by: Stephan Kulla <git.mail@kulla.me>
Co-authored-by: Stephan Kulla <git.mail@kulla.me>
Co-authored-by: Stephan Kulla <git.mail@kulla.me>
CodingDive
commented
Nov 30, 2023
|
|
||
| const record = await dataSources.model.serlo.executePrompt({ | ||
| ...payload, | ||
| messages: messages as OpenAIMessages, |
There was a problem hiding this comment.
Is there a nicer way @kulla?
* Check for any empty message * KISS
kulla
approved these changes
Nov 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context window will be built by the frontend for now. Eventually, we'll be able to migrate to the assistance API https://platform.openai.com/docs/assistants/how-it-works/creating-assistants