Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move static pages into entity namespace #1586

Merged
merged 36 commits into from
Jul 10, 2024
Merged

feat: Move static pages into entity namespace #1586

merged 36 commits into from
Jul 10, 2024

Conversation

kulla
Copy link
Member

@kulla kulla commented Jun 14, 2024 •
edited by hugotiburtino
Loading

Fixes #1585 #1556

@kulla kulla linked an issue Jun 14, 2024 that may be closed by this pull request
Merge static pages into entities #1556
Closed
@kulla kulla force-pushed the 1556-merge-static-pages-into-entities branch from 817079c to f3be9b5 Compare June 15, 2024 09:10
@kulla kulla marked this pull request as ready for review June 15, 2024 09:19
@kulla
Copy link
Member Author

kulla commented Jun 15, 2024

This PR is ready to be merged 😄 @hugotiburtino

@kulla kulla mentioned this pull request Jun 15, 2024
Closed
60 tasks
@kulla kulla force-pushed the 1556-merge-static-pages-into-entities branch from 400145a to 317857c Compare June 15, 2024 10:36
hugotiburtino
hugotiburtino approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@hugotiburtino hugotiburtino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration will be moved to the serlo/db-migrations first

packages/server/src/schema/uuid/page/resolvers.ts Show resolved Hide resolved
@hugotiburtino hugotiburtino merged commit 42e2f51 into staging Jul 10, 2024
9 checks passed
@hugotiburtino hugotiburtino deleted the 1556-merge-static-pages-into-entities branch July 10, 2024 11:18
@hugotiburtino hugotiburtino mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugotiburtino hugotiburtino hugotiburtino approved these changes

@elbotho elbotho Awaiting requested review from elbotho

@AndreasHuber AndreasHuber Awaiting requested review from AndreasHuber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge static pages into the entity and entity_revision table Merge static pages into entities
2 participants
@kulla @hugotiburtino