fix(alias): encode path again to match the alias in database #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the encoded path was sent to the database layer. It is strange that we decode, encode and decode it again, can't see the reason for it now. We may try not to encode it at all in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the encoded path was sent to the database layer. It is strange that we decode, encode and decode it again
See the old code in https://github.com/serlo/api.serlo.org/pull/1573/files
I can't see the reason for this repetition back then. We may try to just decode once and not encode at all.
https://de.serlo-staging.dev/community/neue-f%C3%A4cher-themen is now working again. Unfortunatelly some Spanish alias aren't working still, I'll keep investigating.