feat: Use the database while trying to reconnect to Redis #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retries were reduced in order that the user get the data more quickly. Solves #1430
hugotiburtino
commented
Jul 17, 2024
| }) | ||
|
|
||
| const lockManagers: Record<Priority, LockManager> = { | ||
| [Priority.Low]: createLockManager({ | ||
| retryCount: 0, | ||
| }), | ||
| [Priority.High]: createLockManager({ | ||
| retryCount: 10, | ||
| retryCount: 5, |
There was a problem hiding this comment.
The retry was reduced (also at line 31 maxRetriesPerRequest: 3, it is by default 20) in order that the user don't wait that much
hugotiburtino
commented
Jul 17, 2024
| error, | ||
| location: 'Cache lockManager', | ||
| }) | ||
| client.disconnect() |
There was a problem hiding this comment.
Since it will keep logging from the line 34, we don't need two or three sentry events for the same problem, so, disconnecting stop logging from the lock manager.
This was referenced Jul 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides that, it keeps logging to Sentry, which should warn us.