chore: Add mysql database #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugotiburtino
commented
Jul 9, 2024
| @@ -0,0 +1,5 @@ | |||
| import mysql from 'mysql2/promise' | |||
|
|
|||
| export const connection = await mysql.createConnection('mysql://root:secret@localhost/itslearning') | |||
There was a problem hiding this comment.
Suggested change
| export const connection = await mysql.createConnection('mysql://root:secret@localhost/itslearning') | |
| export const connection = await mysql.createConnection('mysql://root:secret@localhost/serlo') |
hugotiburtino
commented
Jul 9, 2024
| @@ -0,0 +1,57 @@ | |||
| -- MySQL dump 10.13 Distrib 8.4.0, for Linux (x86_64) | |||
There was a problem hiding this comment.
Since we are using the serlo database , this should be deleted
serlo/api.serlo.org#1665
hugotiburtino
commented
Jul 9, 2024
Comment on lines
+2
to
+9
| mysql: | ||
| image: mysql:8 | ||
| ports: | ||
| - '3306:3306' | ||
| environment: | ||
| - MYSQL_ROOT_PASSWORD=secret | ||
| volumes: | ||
| - ./docker-entrypoint-initdb.d:/docker-entrypoint-initdb.d |
There was a problem hiding this comment.
Suggested change
| mysql: | |
| image: mysql:8 | |
| ports: | |
| - '3306:3306' | |
| environment: | |
| - MYSQL_ROOT_PASSWORD=secret | |
| volumes: | |
| - ./docker-entrypoint-initdb.d:/docker-entrypoint-initdb.d | |
| mysql: | |
| image: eu.gcr.io/serlo-shared/serlo-mysql-database:latest | |
| platform: linux/x86_64 | |
| pull_policy: always | |
| ports: | |
| - '3306:3306' |
|
@hejtful maybe you want to see my suggestions and adapt this code to the new needs. |
|
Thank you Hugo for the suggestions! I'll close this PR because it drifted apart from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to simulate the use of our mysql database for itslearning lti resources.