Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fallible font methods on Font struct #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add fallible font methods on Font struct #64

wants to merge 1 commit into from

Conversation

acarl005
Copy link

Adds more fallible font methods a. la #62

The naming conventions for this struct were a little different, not have get_ prefixes. As such, the new names we're as obvious. I added try_ prefixes but please let me know if there is a better suggestion.

mrobinson
mrobinson requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. I think we should be consistent with the naming. Maybe simply modify the return value of these functions and we can save this change for right before a API-breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acarl005 @mrobinson