Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in CI. #540

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Fix errors in CI. #540

merged 4 commits into from
Jun 5, 2024

Conversation

jdm
Copy link
Member

@jdm jdm commented Jun 5, 2024

From the lint job:

 error: methods `get_bool` and `get_list` are never used
   --> rcdom/tests/xml-tokenizer.rs:147:8
    |
143 | trait JsonExt: Sized {
    |       ------- methods in this trait
...
147 |     fn get_bool(&self) -> bool;
    |        ^^^^^^^^
148 |     fn get_obj(&self) -> &Map<String, Self>;
149 |     fn get_list(&self) -> &Vec<Self>;
    |        ^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

From the nightly CI:

error: unexpected `cfg` condition name: `trace_tokenizer`
   --> html5ever/src/tokenizer/mod.rs:625:11
    |
625 | #[cfg(not(trace_tokenizer))]
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(trace_tokenizer)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(trace_tokenizer)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

@mrobinson mrobinson added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit dfb81ce Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants