New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linear extrapolation of endpoint samples in AudioBufferSourceNode #331

Merged

bors-servo merged 2 commits into servo:master from khodzha:issue_300_2

Jan 28, 2020

Contributor

khodzha commented Jan 27, 2020

issue #300

running test https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling.html after this patch results in:


          linear extrapolation of endpoint samples in AudioBufferSourceNode

f5f10c4

Member

Manishearth commented Jan 28, 2020

Manishearth approved these changes

View reviewed changes

Member

Manishearth left a comment

Can you also fix the warning that's failing appveyor?


          style fix for PannerNode

b5f1516

Contributor Author

khodzha commented Jan 28, 2020

should i squash these commits?

Member

Manishearth commented Jan 28, 2020

nah, they do different things and apply independently

Thanks!

Contributor

bors-servo commented Jan 28, 2020

📌 Commit b5f1516 has been approved by Manishearth

Contributor

bors-servo commented Jan 28, 2020

⌛ Testing commit b5f1516 with merge bc8c7f7...

bors-servo pushed a commit that referenced this pull request


          Auto merge of #331 - khodzha:issue_300_2, r=Manishearth

bc8c7f7

linear extrapolation of endpoint samples in AudioBufferSourceNode

issue #300

running test https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling.html after this patch results in:
![test results](https://user-images.githubusercontent.com/1618874/73188805-79746f00-4134-11ea-9fca-47b0c5868685.png)

Contributor

bors-servo commented Jan 28, 2020

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing bc8c7f7 to master...

bors-servo merged commit b5f1516 into servo:master

khodzha deleted the issue_300_2 branch

January 28, 2020 10:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet