Make ServoMedia::get infallible #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was already infallible before, but returned a Result type for unknown reasons. The relevant Code hasn't been touched for 7 years. I think the original intention was to make backend creation fallible, but as mentioned before it currently isn't, and even if it were it seems more reasonable to return a Result from ServoMedia::init. Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
infallible-backend-get
branch
from
5888ecd to
a9f4ab8
Compare
|
Should we release a new crate version given that this is a breaking change or do we not care about that since |
|
We don't care about that since it's never been published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already infallible before, but returned
a Result type for unknown reasons. The relevant
Code hasn't been touched for 7 years.
I think the original intention was to make backend creation fallible, but as mentioned before
it currently isn't. And even if it were fallible it seems more reasonable to return a Result from
ServoMedia::init instead.