Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mozjs_sys version to 0.115.7-0 #456

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Bump mozjs_sys version to 0.115.7-0 #456

merged 1 commit into from
Mar 8, 2024

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Mar 6, 2024

In #454 we got the need to have versioned mozjs-sys (even if unpublished) for artifact purposes so I proposed the following versioning for mozjs-sys (modeled after what we used before we give up on versioning):
0.{SM-major}.{SM-minor}-# where # is sequential number that is incremented for every C/C++ change in same SM version.

So we would start with 0.115.7-0 (we currently use SM 115.7) then for every C* change increment last number (0.115.7-1) until we move on to new SM 0.115.9-0 that would again start with new number.

CC @jdm @mrobinson @wusyong

@wusyong
Copy link
Member

wusyong commented Mar 7, 2024

Maybe it can just use major version already? So it can be like this: {SM-major}.{SM-minor}.{#}, and the current version could be 115.7.1.

@sagudev
Copy link
Member Author

sagudev commented Mar 7, 2024

Maybe it can just use major version already? So it can be like this: {SM-major}.{SM-minor}.{#}, and the current version could be 115.7.1.

Then # changes could not be breaking if we want to uphold semver. We can move to that scheme in the future when we feel mozjs is stable enough.

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheme makes sense to me.

@sagudev sagudev added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 8190669 Mar 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants