Arc should not be Traceable #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traceable works under the assumption that only one thread will be looking at values. The entire purpose of `Arc` is to share things between threads. This ~never works (unless the Arc could be replaced by a Rc). Nothing in this crate or servo uses this impl. Let's just delete this. Signed-off-by: Greg Morenz <greg-morenz@droid.cafe>
sagudev
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traceable works under the assumption that only one thread will be looking at values. The entire purpose of
Arcis to share things between threads. This never works (unless the Arc could be replaced by a Rc), and won't no matter how mutability is handled.Nothing in this crate or servo uses this impl. Let's just delete this.