Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harfbuzz-sys: Use dep syntax. #262

Merged

Conversation

waywardmonkeys
Copy link
Collaborator

This prevents creating implicit features for core-graphics, core-text, foreign-types, freetype-sys, and windows.

Before:

❯ cargo add harfbuzz-sys
    Updating crates.io index
      Adding harfbuzz-sys v0.6.1 to dependencies
             Features:
             + core-graphics
             + core-text
             + coretext
             + directwrite
             + foreign-types
             + freetype
             + freetype-sys
             + winapi
             - bundled
    Updating crates.io index

After:

❯ cargo add harfbuzz-sys --path ../rust-harfbuzz/harfbuzz-sys
      Adding harfbuzz-sys (local) to dependencies
             Features:
             + coretext
             + directwrite
             + freetype
             - bundled
    Updating crates.io index

This prevents creating implicit features for `core-graphics`,
`core-text`, `foreign-types`, `freetype-sys`, and `windows`.
@mrobinson mrobinson added this pull request to the merge queue Jul 21, 2024
Merged via the queue into servo:main with commit e0a67df Jul 21, 2024
8 checks passed
@waywardmonkeys waywardmonkeys deleted the harfbuzz-sys-use-explicit-features branch July 22, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants