Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to force GLES usage on Linux #305

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

webbeef
Copy link
Contributor

@webbeef webbeef commented Aug 15, 2024

No description provided.

@jdm
Copy link
Member

jdm commented Aug 15, 2024

Have you verified that this actually works? For example, there's another instance of this in device.rs in the same directory.

@webbeef
Copy link
Contributor Author

webbeef commented Aug 16, 2024

Yes, on a Pinephone Pro this worked with the initial patch, but I updated it with your suggestion.

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable quick fix to expose the functionality.

@jdm jdm enabled auto-merge August 16, 2024 02:49
@webbeef
Copy link
Contributor Author

webbeef commented Aug 16, 2024

Thanks! Do you plan to do a new release in the near future?

@jdm
Copy link
Member

jdm commented Aug 16, 2024

Yeah, I'll publish 0.9.6 once this merges.

@jdm jdm added this pull request to the merge queue Aug 16, 2024
Merged via the queue into servo:main with commit a26e707 Aug 16, 2024
17 checks passed
@webbeef webbeef deleted the force-gles branch August 16, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants