replace implementation module with declarative macro #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach of having a free standing module that is instantiated multiple times with the explicit `path` often causes confusion when reading the code. So replace this with a very simple declarative macro that hopefully is more explicit and simpler than the current approach. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
mukilan
force-pushed
the
replace-implementation-mod
branch
from
08c4934 to
75a61d2
Compare
wusyong
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach of having a free standing module that is instantiated multiple times with the explicit
pathoften causes confusion when reading the code. So replace this with a very simple declarative macro that hopefully is more explicit and simpler than the current approach.