refactor: Fix clippy warnings

src/fsutil.rs

@@ -3,12 +3,14 @@ use std::cmp;
 use std::io::{self, Write};
 use std::path::{Path, PathBuf};
 
+pub type Callback = dyn Fn(&Path, &Path, &io::Error);
+
 pub fn move_files(
     actions: &[Action],
     dry_run: bool,
     interactive: bool,
     verbose: bool,
-    on_error: Option<&dyn Fn(&Path, &Path, &io::Error)>,
+    on_error: Option<&Callback>,
 ) -> i32 {
     let mut num_errors = 0;
 

src/lib.rs

@@ -34,7 +34,7 @@ pub fn print_error<S: AsRef<str>>(msg: S) {
     }
 
     let msg = msg.as_ref();
-    if let Err(_) = do_print(msg) {
+    if do_print(msg).is_err() {
         eprintln!("error: {}", msg);
     }
 }
@@ -139,7 +139,7 @@ pub fn try_main(args: &[OsString]) -> Result<(), String> {
     let config = parse_args(args);
 
     // Collect paths of the files to move with their destination
-    let actions = matches_to_actions(config.src_ptn.as_str(), config.dest_ptn.as_str());
+    let actions = matches_to_actions(&config.src_ptn, &config.dest_ptn);
 
     let actions = sort_actions(&actions)?;
 

src/main.rs

@@ -4,7 +4,7 @@ use std::ffi::OsString;
 use pmv::{print_error, try_main};
 
 fn main() -> Result<(), ()> {
-    let args: Vec<OsString> = env::args_os().into_iter().collect();
+    let args: Vec<OsString> = env::args_os().collect();
 
     if let Err(err) = try_main(&args[..]) {
         print_error(err);