Skip to content

Commit

Permalink
Fix Laravel 7 support (fixes #9)
Browse files Browse the repository at this point in the history
  • Loading branch information
shalvah committed Jun 25, 2020
1 parent 8c3e452 commit 2af09d0
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 21 deletions.
5 changes: 3 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
language: php

php:
- 7.1.3
- 7.2.1
- 7.2.5
- 7.3
- 7.4

before_script:
- travis_retry composer install --no-interaction --prefer-source
Expand Down
20 changes: 13 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
# laravel-jsend

[![Latest Stable Version](https://poser.pugx.org/shalvah/laravel-jsend/v/stable)](https://packagist.org/packages/shalvah/laravel-jsend) [![Total Downloads](https://poser.pugx.org/shalvah/laravel-jsend/downloads)](https://packagist.org/packages/shalvah/laravel-jsend)
[![Latest Stable Version](https://poser.pugx.org/shalvah/laravel-jsend/v/stable)](https://packagist.org/packages/shalvah/laravel-jsend)
[![Total Downloads](https://poser.pugx.org/shalvah/laravel-jsend/downloads)](https://packagist.org/packages/shalvah/laravel-jsend)
[![Build Status](https://travis-ci.com/shalvah/laravel-jsend.svg?branch=master)](https://travis-ci.com/shalvah/laravel-jsend)

Simple helpers to generate [JSend-compliant](https://labs.omniti.com/labs/jsend) responses for your Laravel app

The [JSend specification](https://labs.omniti.com/labs/jsend) lays down some rules for how JSON responses from web servers should be formatted. JSend is especially suited for REST-style applications and APIs.

## Installation
Laravel 7 and above:
```bash
composer require shalvah/laravel-jsend
```

Laravel 5.1 - 6.*:
```bash
composer require shalvah/laravel-jsend:^1.0
```

## Usage
In your controller:

Expand Down Expand Up @@ -122,11 +134,5 @@ return jsend_fail(["location_id" => "Location not found"], 404);
return jsend_error("Unable to connect to database", 'E0001', [], 503, ["X-My-Header" => "header value"]);
```

## Installation

```bash
composer require shalvah/laravel-jsend
```

## License
MIT
13 changes: 4 additions & 9 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
}
],
"require": {
"php": ">=5.6.4",
"laravel/framework": "^5.1|^6.0|^7.0",
"orchestra/testbench": "^3.6|^5.0"
"php": ">=7.2.5",
"laravel/framework": "^7.0",
"orchestra/testbench": "^5.0"
},
"require-dev": {
"phpunit/phpunit": "^5.0 || ^6.0 || ^7.3"
"phpunit/phpunit": "^8.0"
},
"autoload": {
"files": [
Expand All @@ -37,10 +37,5 @@
},
"scripts": {
"test": "phpunit tests"
},
"config": {
"platform": {
"php": "7.1.3"
}
}
}
6 changes: 3 additions & 3 deletions src/JsendExceptionFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

namespace Shalvah\LaravelJsend;

use Exception;
use Throwable;
use Illuminate\Support\Arr;
use Illuminate\Validation\ValidationException;

/**
* @mixin \App\Exceptions\Handler
* @mixin \Illuminate\Foundation\Exceptions\Handler
*/
trait JsendExceptionFormatter
{
Expand All @@ -33,7 +33,7 @@ protected function invalidJson($request, ValidationException $exception)
* @param \Exception $e
* @return \Illuminate\Contracts\Routing\ResponseFactory|\Symfony\Component\HttpFoundation\Response
*/
protected function prepareJsonResponse($request, Exception $e)
protected function prepareJsonResponse($request, Throwable $e)
{
$message = 'Server Error';
if (config('app.debug') || $this->isHttpException($e)) {
Expand Down

0 comments on commit 2af09d0

Please sign in to comment.