This repository was archived by the owner on Dec 20, 2019. It is now read-only.
Make filter-from-backend return a lazy seq #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to reduce the memory overhead when there are many keys in a given location when trying to use filter-from-backend. Actual calls to s3 are lazy and only perform IO as the sequence is consumed.
| (lazy-cat accum | ||
| (filter-from-backend conf | ||
| location | ||
| (lazy-cat accum values) |
There was a problem hiding this comment.
You're lazy-cating accum twice?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is meant to reduce the memory overhead when there are many keys in
a given location when trying to use filter-from-backend. Actual calls to
s3 are lazy and only perform IO as the sequence is consumed.
Tests
Reviewers
@jeremyheiler @nathants