Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DekuWrite for [T] #270

Closed
constfold opened this issue Jun 28, 2022 · 1 comment
Closed

Implement DekuWrite for [T] #270

constfold opened this issue Jun 28, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@constfold
Copy link
Contributor

Currently we alreay have DekuWrite for &[T], I think there is no reason to not have DekuWrite on [T]. I found this would be convenience while write codes like:

self.0.as_ref().write(output, ()) // not work, type annotations needed
<&[u8]>::write(self.0.as_ref(), output, ()) // not work either
<&[u8]>::write(&self.0.as_ref(), output, ()) // works
<[u8]>::write(self.0.as_ref(), output, ()) // works
@constfold constfold changed the title Implement DekuWrite for [u8] Implement DekuWrite for [T] Jun 28, 2022
@sharksforarms sharksforarms added the enhancement New feature or request label Jul 4, 2022
@sharksforarms sharksforarms mentioned this issue Jan 1, 2023
Open
wcampbell0x2a added a commit that referenced this issue Jan 24, 2024
@wcampbell0x2a
Impl DekuWrite for [T]
894b4ca 
- Remove already removed gated feature testing
- Add test for [T]

See #270
wcampbell0x2a added a commit that referenced this issue Jan 24, 2024
@wcampbell0x2a
Impl DekuWrite for [T]
b00002b 
- Remove already removed gated feature testing
- Add test for [T]

See #270
@wcampbell0x2a wcampbell0x2a mentioned this issue Jan 24, 2024
Merged
wcampbell0x2a added a commit that referenced this issue Jan 24, 2024
@wcampbell0x2a
Impl DekuWrite for [T] (#416)
dd6bd04 
- Remove already removed gated feature testing
- Add test for [T]

See #270
@wcampbell0x2a
Copy link
Collaborator

Should be closed with #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sharksforarms @wcampbell0x2a @constfold