Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl DekuWrite for [T] #416

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Impl DekuWrite for [T] #416

merged 1 commit into from
Jan 24, 2024

Conversation

wcampbell0x2a
Copy link
Collaborator

  • Remove already removed gated feature testing
  • Add test for [T]

See #270

@wcampbell0x2a
Impl DekuWrite for [T]
b00002b 
- Remove already removed gated feature testing
- Add test for [T]

See #270
@github-actions GitHub Actions
Copy link

Benchmark for 8d6744e

Click to view benchmark
Test Base PR %
deku_read_bits 1266.8±15.23ns 1198.6±36.37ns -5.38%
deku_read_byte 19.9±0.45ns 20.0±0.41ns +0.50%
deku_read_enum 9.3±0.18ns 9.4±0.15ns +1.08%
deku_read_vec 53.3±0.89ns 53.4±0.77ns +0.19%
deku_write_bits 110.2±4.02ns 110.0±1.05ns -0.18%
deku_write_byte 126.4±3.09ns 129.2±4.98ns +2.22%
deku_write_enum 93.1±5.94ns 94.7±3.79ns +1.72%
deku_write_vec 3.1±0.06µs 3.1±0.07µs 0.00%

@wcampbell0x2a wcampbell0x2a merged commit dd6bd04 into master Jan 24, 2024
15 checks passed
@wcampbell0x2a wcampbell0x2a deleted the impl-deku-write-array-T branch January 24, 2024 02:14
@wcampbell0x2a wcampbell0x2a mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharksforarms sharksforarms sharksforarms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcampbell0x2a @sharksforarms