Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include source code of libraries used for static builds #85

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

sharkwouter
Copy link
Owner

This is very broken, but some pieces of it should be usable.

@sharkwouter
Copy link
Owner Author

Currently the Linux build from this branch segfaults on something related to pulse audio.

@sharkwouter
Copy link
Owner Author

sharkwouter commented Nov 21, 2024

The Windows build works. It is much better than the master branch build, because it barely includes any libraries.

@sharkwouter
Copy link
Owner Author

The Windows executable is more than 30 MB smaller with this change.

@sharkwouter
Copy link
Owner Author

The system of enabling translation support still needs a fix. Since tinygettext is always included for static builds and it is even build if it was already found.

This excludes SDL2 itself, because builds of it are often platform
specific and I would only be able to include the upstream version.
@sharkwouter sharkwouter marked this pull request as ready for review November 21, 2024 12:07
@sharkwouter sharkwouter changed the title Include dependencies Include source code of libraries used for static builds Nov 21, 2024
@sharkwouter sharkwouter merged commit b6bccdd into master Nov 21, 2024
5 checks passed
@sharkwouter sharkwouter deleted the include-dependencies branch November 21, 2024 12:08
@sharkwouter sharkwouter added this to the Version 2.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant