Merge branch 'fix-state-bleeding-in-js' of https://github.com/sherlo-…

…io/sherlo into fix-state-bleeding-in-js
sherlo-io · Nov 28, 2024 · 5f4872d · 5f4872d
2 parents 38a92e1 + db6eda6
commit 5f4872d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/expo-update.yml b/.github/workflows/expo-update.yml
@@ -65,7 +65,7 @@ jobs:
             --config ../../configs/${{ inputs.config }}.json \
             --android builds/development/android.apk \
             --ios builds/development/ios.tar.gz \
-            --channel development \
+            --branch development \
             --token ${{ inputs.project == 'expo-update' && secrets.SHERLO_EXPO_UPDATE_TOKEN || inputs.project == 'many-stories' && secrets.SHERLO_MANY_STORIES_TOKEN || inputs.project == 'device-testing' && secrets.SHERLO_ALL_DEVICES_TOKEN }}
 
       - name: Run sherlo expo-update (without native builds)
@@ -74,5 +74,5 @@ jobs:
         run: |
           yarn sherlo expo-update \
             --config ../../configs/${{ inputs.config }}.json \
-            --channel development \
+            --branch development \
             --token ${{ inputs.project == 'expo-update' && secrets.SHERLO_EXPO_UPDATE_TOKEN || inputs.project == 'many-stories' && secrets.SHERLO_MANY_STORIES_TOKEN || inputs.project == 'device-testing' && secrets.SHERLO_ALL_DEVICES_TOKEN }}
diff --git a/packages/react-native-storybook/src/helpers/SherloModule.ts b/packages/react-native-storybook/src/helpers/SherloModule.ts
@@ -91,6 +91,7 @@ function normalizePath(path: string): string {
 
 function createDummySherloModule(): SherloModule {
   return {
+    checkIfContainsStorybookError: async () => false,
     clearFocus: async () => {},
     getInspectorData: async () => '',
     storybookRegistered: async () => {},