[WIP] m133.6943 ビルドエラーの対応 #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miosakuma
force-pushed
the
feature/fix-m133.6943
branch
from
8a0f155 to
425ba40
Compare
miosakuma
commented
Feb 5, 2025
| - cflags += [ "-Wa,--crel,--allow-experimental-crel" ] | ||
| - } | ||
| - } | ||
|
|
There was a problem hiding this comment.
追加された処理を削除する方向で対処しました。
is_linux のときに入る分岐であり、ios / mac には不要と判断したためです。
miosakuma
commented
Feb 5, 2025
| - if (is_linux && !llvm_android_mainline && current_cpu != "arm" && | ||
| - default_toolchain != "//build/toolchain/cros:target") { | ||
| - cflags += [ "-Wa,--crel,--allow-experimental-crel" ] | ||
| - } |
There was a problem hiding this comment.
追加された処理を削除する方向で対処しました。
is_linux のときに入る分岐であり、ios / mac には不要と判断したためです。
miosakuma
commented
Feb 5, 2025
| ++ ":proxy_info", | ||
| + ] | ||
| + absl_deps = [ "//third_party/abseil-cpp/absl/strings" ] | ||
| + } |
There was a problem hiding this comment.
今回のパッチエラーとは関連していませんが、BUILD.gn.rej に対する差分が含まれていたため削除しました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応完了状況
パッチの修正についてのコメント