Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements event-driven promises capability through the aio callback mechanism #29

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

shikokuchuo
Copy link
Owner

Thanks @jcheng5 for the prototype in #28 .

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 10.16949% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 88.06%. Comparing base (b08f27a) to head (b8ed236).
Report is 6 commits behind head on main.

❗ Current head b8ed236 differs from pull request most recent head e8226fb. Consider uploading reports for the commit e8226fb to get more accurate results

Files Patch % Lines
src/aio.c 10.41% 43 Missing ⚠️
R/context.R 0.00% 8 Missing ⚠️
src/later_shim.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   89.55%   88.06%   -1.49%     
==========================================
  Files          23       24       +1     
  Lines        3139     3193      +54     
==========================================
+ Hits         2811     2812       +1     
- Misses        328      381      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shikokuchuo shikokuchuo merged commit 7bcda06 into main Apr 18, 2024
12 checks passed
@shikokuchuo shikokuchuo deleted the dev branch April 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants