Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-latest-16-cores from CNCF for e2e #1786

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Jan 26, 2025

Changes

In e2e we had disk space issues and therefore used the maximize-build-space action. We still sometimes had failures and with the more complex cluster setup needed in #1711, we need again more disk space.

Switching to the larger custom runners that we get from CNCF for e2e tests. They have more than 500 G disk space, that will be enough for us.

With the additional compute power, e2e completes in ≈ 21 minutes instead of ≈ 35 minutes. (We run ginkgo with -p without any explicit parallism. It automatically used 15. See "Running in parallel across 15 processes" in logs, the default workers had just 4).

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jan 26, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2025
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Jan 26, 2025
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-ubuntu-latest-16-cores-e2e branch from e80d22e to d24638a Compare January 26, 2025 16:37
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Jan 26, 2025
@SaschaSchwarze0 SaschaSchwarze0 changed the title WIP Use ubuntu-latest-16-cores from CNCF for e2e Use ubuntu-latest-16-cores from CNCF for e2e Jan 26, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2025
@SaschaSchwarze0 SaschaSchwarze0 added kind/flake Categorizes issue or PR as related to a flaky test. and removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jan 26, 2025
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Awesome that we can use beefier GitHub actions instances!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cb64822 into shipwright-io:main Jan 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants