Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.23 everywhere #1788

Merged

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Go 1.24 is expected to be shipped in February. Then, 1.22 will be EOS. Now is therefore a good time to start building with Go 1.23.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

All binaries are now compiled with Go 1.23

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jan 27, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Jan 27, 2025
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jan 27, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2025
@openshift-ci openshift-ci bot requested a review from apoorvajagtap January 27, 2025 14:22
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@apoorvajagtap
Copy link
Member

Quick question, are we planning to bump the version in go.mod separately? Might help to bump that too in the same PR.

@SaschaSchwarze0
Copy link
Member Author

Quick question, are we planning to bump the version in go.mod separately? Might help to bump that too in the same PR.

No, I stop go.mod bumping. The go.mod defines which version is necessary to compile and should be based on which Go language capabilities are used. By using a newer compiler, we have not started using Go 1.23 language feature which means that we can keep go.mod untouched so that people who still want (or have to) compile with Go 1.22 will still be happy. Having said that, it will anyway be bumped by our dependencies either using Go 1.23 language features or by incorrectly declaring what they need. This will already be the case with #1777.

@apoorvajagtap
Copy link
Member

No, I stop go.mod bumping. The go.mod defines which version is necessary to compile and should be based on which Go language capabilities are used. By using a newer compiler, we have not started using Go 1.23 language feature which means that we can keep go.mod untouched so that people who still want (or have to) compile with Go 1.22 will still be happy. Having said that, it will anyway be bumped by our dependencies either using Go 1.23 language features or by incorrectly declaring what they need. This will already be the case with #1777.

Got it. Thanks for sharing this!

@apoorvajagtap
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@apoorvajagtap
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e39c0de into shipwright-io:main Jan 30, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants