-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Go 1.23 everywhere #1788
Use Go 1.23 everywhere #1788
Conversation
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
d025752
to
ecbac97
Compare
Quick question, are we planning to bump the version in go.mod separately? Might help to bump that too in the same PR. |
No, I stop go.mod bumping. The go.mod defines which version is necessary to compile and should be based on which Go language capabilities are used. By using a newer compiler, we have not started using Go 1.23 language feature which means that we can keep go.mod untouched so that people who still want (or have to) compile with Go 1.22 will still be happy. Having said that, it will anyway be bumped by our dependencies either using Go 1.23 language features or by incorrectly declaring what they need. This will already be the case with #1777. |
Got it. Thanks for sharing this! |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apoorvajagtap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Go 1.24 is expected to be shipped in February. Then, 1.22 will be EOS. Now is therefore a good time to start building with Go 1.23.
Submitter Checklist
Release Notes