Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1567] Release Workflow Action No Longer Maintained #1796

Conversation

subhasree91
Copy link

@subhasree91 subhasree91 commented Feb 6, 2025

Changes

  • Modify the "Draft release" task to use the gh command line tool instead of the actions/create-release action

Fixes #1567

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fixed deprecated release-actions in favor of gh command line.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2025
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Feb 6, 2025
@openshift-ci openshift-ci bot requested review from karanibm6 and qu1queee February 6, 2025 12:38
@subhasree91 subhasree91 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Feb 6, 2025
@subhasree91 subhasree91 force-pushed the 1567_modify_draft-release_with_gh branch from e9126b5 to 39f7678 Compare February 6, 2025 12:43
@qu1queee qu1queee requested review from SaschaSchwarze0 and removed request for qu1queee February 6, 2025 12:52
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One small change.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
- Modify the "Draft release" task to use the gh command line tool instead of the actions/create-release action

Signed-off-by: Subhasree-Das <Subhasree.Das@ibm.com>
@subhasree91 subhasree91 force-pushed the 1567_modify_draft-release_with_gh branch from 39f7678 to 9c8069c Compare February 10, 2025 05:06
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Feb 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 592a6c5 into shipwright-io:main Feb 10, 2025
19 checks passed
@subhasree91 subhasree91 deleted the 1567_modify_draft-release_with_gh branch February 10, 2025 08:47
@adambkaplan
Copy link
Member

Thank you @subhasree91! This "pays off" very important tech debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[tech-debt] Release Workflow Action No Longer Maintained
4 participants