fix(propagation): show last modified propagated documentation (datahu…

…b-project#11498)
shirshanka · Oct 7, 2024 · 7bdb7bb · 7bdb7bb
1 parent 7884c85
commit 7bdb7bb
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/...b-web-react/src/app/entity/shared/tabs/Dataset/Schema/utils/getFieldDescriptionDetails.ts b/...b-web-react/src/app/entity/shared/tabs/Dataset/Schema/utils/getFieldDescriptionDetails.ts
@@ -7,19 +7,29 @@ interface Props {
 }
 
 export function getFieldDescriptionDetails({ schemaFieldEntity, editableFieldInfo, defaultDescription }: Props) {
-    const documentation = schemaFieldEntity?.documentation?.documentations?.[0];
-    const isUsingDocumentationAspect = !editableFieldInfo?.description && !!documentation;
+    const documentations = schemaFieldEntity?.documentation?.documentations;
+    let latestDocumentation: typeof documentations[0] | undefined;
+
+    if (documentations && documentations.length > 0) {
+        latestDocumentation = documentations.reduce((latest, current) => {
+            const latestTime = latest.attribution?.time || 0;
+            const currentTime = current.attribution?.time || 0;
+            return currentTime > latestTime ? current : latest;
+        });
+    }
+
+    const isUsingDocumentationAspect = !editableFieldInfo?.description && !!latestDocumentation;
     const isPropagated =
         isUsingDocumentationAspect &&
-        !!documentation?.attribution?.sourceDetail?.find(
+        !!latestDocumentation?.attribution?.sourceDetail?.find(
             (mapEntry) => mapEntry.key === 'propagated' && mapEntry.value === 'true',
         );
 
     const displayedDescription =
-        editableFieldInfo?.description || documentation?.documentation || defaultDescription || '';
+        editableFieldInfo?.description || latestDocumentation?.documentation || defaultDescription || '';
 
-    const sourceDetail = documentation?.attribution?.sourceDetail;
-    const propagatedDescription = documentation?.documentation;
+    const sourceDetail = latestDocumentation?.attribution?.sourceDetail;
+    const propagatedDescription = latestDocumentation?.documentation;
 
     return { displayedDescription, isPropagated, sourceDetail, propagatedDescription };
 }