Skip to content

Commit

Permalink
Merge pull request #262 from shorepine/nochorus
Browse files Browse the repository at this point in the history
turning off chorus for piano voice
  • Loading branch information
bwhitman authored Jan 6, 2025
2 parents ad79b46 + 455088a commit 37d3a62
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions amy_headers.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ def make_piano_patch():
import amy
# This just allocates the 20 oscs needed for a INTERP_PARTIALS patch
# dpwe wants to add a `num_suboscs` field to fix this behavior soon
amy.send(chorus=0) # Piano sounds weird with chorus on
amy.send(osc=0, wave=amy.INTERP_PARTIALS, patch=0)
amy.send(osc=20, wave=amy.PARTIAL)
return 21
Expand Down
2 changes: 1 addition & 1 deletion src/patches.h
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ static const char * const patch_commands[257] PROGMEM = {
/* 253: DX7 GRAND PRIX */ "v1A0,0.000188,369,0.229251,2273,0.068157,1665,0.000188,3636,0.000188P0.25I0.5L7a0.385553,0,0,1,0,0Zv2A0,0.000188,65,0.229251,3610,0.040526,13,0.007164,1816,0.000188P0.25I0.496875L7a0.044194,0,0,1,0,0Zv3A0,0.000188,289,1,1500,0.068157,9,0.000188,3636,0.000188P0.25I0.5L7a2,0,0,1,0,0Zv4A0,0.000188,64,1,948,0.297302,3481,0.017039,3151,0.000188P0.25I0.5L7a2,0,0,1,0,0Zv5A0,0.000188,0,0.074325,92,0.385553,10564,0.03125,1815,0.000188P0.25I2L7a0.840896,0,0,1,0,0Zv6A0,0.000188,1031,1,10394,0.003906,1263,0.00213,173,0.000188P0.25I4L7a1.090508,0,0,1,0,0Zv7w0f50.29a0.000188Zv8w0f50.29a0.000188Zv0w8o17b0.16O1,2,3,4,5,6A0,1,3636,0.000188B0,0.048389,9275,15.657153,63,2.612474,1683,0.382779,34,0.048389f0,1,0,0,1,1L8Z",
/* 254: DX7 ST.HELENS */ "v1A0,0.420448,1126,1,17871,0.000188,0,1,2004,0.420448P0.25I0.745L7a1.542211,0,0,1,0,0Zv2A0,0.458502,6818,0.000188,0,0.000188,0,1,2000,0.458502P0.25I0.6L7a1.834008,0,0,1,0,0Zv3A0,0.420448,4308,0.000188,0,0.000188,0,1,1805,0.420448P0.25I0.615L7a1.189207,0,0,1,0,0Zv4A0,0.297302,13805,0.000188,0,0.000188,0,1,2805,0.297302P0.25I0.545L7a1.681793,0,0,1,0,0Zv5A0,0.297302,70,1,25166,0.001381,7616,0.000188,1852,0.297302P0.25I0.515L7a1.090508,0,0,1,0,0Zv6A0,0.32421,67,1,25166,0.001381,7616,0.000188,427,0.32421P0.25I0.5L7a2,0,0,1,0,0Zv7w0f0.064a0.000188Zv8w0f0.064a0.000188Zv0w8o17b0.16O1,2,3,4,5,6A0,1,2805,0.297302B0,0.346878,37,0.048389,9,0.105447,12,0.231848,9,0.346878f0,1,0,0,1,1L8Z",
/* 255: DX7 EXPLOSION */ "v1A0,0.000188,0,1,2,0.297302,85000,0.000188,60000,0.000188P0.25I0.515L7a2,0,0,1,0,0Zv2A0,0.000188,0,1,43,0.707107,11176,0.000188,24000,0.000188P0.25I8.3825L7a0.068157,0,0,1,0,0Zv3A0,0.000188,0,1,43,0.707107,11176,0.000188,31344,0.000188P0.25I0.51L7a2,0,0,1,0,0Zv4A0,0.000188,0,0.297302,99,1,10443,0.000188,26295,0.000188P0.25I0.654375L7a0.5,0,0,1,0,0Zv5A0,0.000188,0,1,37,0.594604,13577,0.000188,14765,0.000188P0.25f100L7a0.458502,0,0,1,0,0Zv6A0,0.000188,0,1,0,1,11647,0.000188,21858,0.000188P0.25I0.495625L7a0.162105,0,0,1,0,0Zv7w4f50.29a0.000188Zv8w4f50.29a0.000188Zv0w8o16b0.01O1,2,3,4,5,6A0,1,60000,0.000188B0,1,0,1,0,1,0,1,12000,1f0,1,0,0,1,1L8Z",
/* 256: dpwe piano */ "v0w12p0Zv20w9Z",
/* 256: dpwe piano */ "k0Zv0w12p0Zv20w9Z",
};
const uint16_t patch_oscs[257] PROGMEM = {
5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,9,21,
Expand Down

0 comments on commit 37d3a62

Please sign in to comment.