Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontendfixes #431

Closed
wants to merge 8 commits into from
Closed

Frontendfixes #431

wants to merge 8 commits into from

Conversation

Rickey07
Copy link

@Rickey07 Rickey07 commented Oct 3, 2023

Description

Overflowing profile-container added , default logo added if there is any error while loading the profile pic.

Related Issues

[Feat;- Dynamic Relatable Issues] #409

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:29am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Rickey07! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli
Copy link
Owner

@Rickey07 Have you run it locally? Because I am seeing two scrollbars on the right side.

@shyamtawli shyamtawli added the enhancement New feature or request label Oct 4, 2023
@Rickey07
Copy link
Author

Rickey07 commented Oct 4, 2023

@shyamtawli One is according to page height and second one is of overflowing container. which one you want to hide?

@shyamtawli
Copy link
Owner

Inside one

@Rickey07
Copy link
Author

Rickey07 commented Oct 5, 2023

@shyamtawli Added different overflowing container and now made the pagination and searchbar sticky and a lso changed the layout dimension model as there were a lot of hardcoded values. Now I've changed it using flexbox please check.

@shyamtawli
Copy link
Owner

Pagination should not be sticky I think. Pagination is also not working smootly.

Other than about layout model changes I know we can fix it more but I am thinking of changing the UI. So let layout be same.

@shyamtawli
Copy link
Owner

Migrated to TailwindCSS PR #852

@shyamtawli shyamtawli closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants