Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#ISSUE-460 used flexbox instead of hard coded values and made search bar sticky #444

Closed
wants to merge 5 commits into from

Conversation

parth305
Copy link

@parth305 parth305 commented Oct 3, 2023

Description

used flex box instead f hard coded values of margin and widths

Changes Proposed

i have changed css to use flex box to style components. search bar and cards where floating over sidebar so i have tried to fix that with flexbox, and i have made search bar sticky.

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 2:00pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @parth305! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli
Copy link
Owner

Hey @parth305 I appreciate your contribution but first you have to open an issue than start working on it.

I like the changes but scroll to top has stopped working, when user click next than scroll to top should take place, look into it and update the PR and also open an issue for it.

@shyamtawli shyamtawli added enhancement New feature or request changes-requested labels Oct 5, 2023
@parth305 parth305 changed the title used flexbox instead of hard coded values and made search bar sticky #ISSUE-460 used flexbox instead of hard coded values and made search bar sticky Oct 5, 2023
@parth305
Copy link
Author

parth305 commented Oct 5, 2023

Hello @shyamtawli i have created issue and fixed the changes you have asked.

please review my PR and merge it with master.

@shyamtawli
Copy link
Owner

Migrated to TailwindCSS PR #852

@shyamtawli shyamtawli closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants