Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide page number in pagination and also total results for current … #572

Closed

Conversation

Jai-Marothiya
Copy link

Description

Add current page number feature as well as number of results on current search

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 8:17pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Jai-Marothiya! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@Jai-Marothiya
Copy link
Author

Hi @shyamtawli,

Merge my pull request with the Hacktoberfest label.

Thanks

@shyamtawli
Copy link
Owner

@Jai-Marothiya Did you open issue for this?

@Jai-Marothiya
Copy link
Author

@shyamtawli I made the changes that I think make this project good. And what do you mean by this?

@shyamtawli
Copy link
Owner

@Jai-Marothiya Try to open an issue first for what ever you are thinking of doing in the project like new feature, fixes, anything. What if I don't like the idea and you have worked hours and I reject it. So try to open an issue issue and describe your ideas there.

I have seen the deployment but only two profiles are showing at a time, we have show 20 profiles a page and also resolve conflicts.

@shyamtawli
Copy link
Owner

Migrated to TailwindCSS PR #852

@shyamtawli shyamtawli closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants