Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add:<HlobisileLukhele> #795

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

HlobisileLukhele
Copy link
Contributor

@HlobisileLukhele HlobisileLukhele commented Jan 2, 2024

Description

Related Issues

Changes Proposed

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 5:38am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @HlobisileLukhele! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

Copy link
Owner

@shyamtawli shyamtawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HlobisileLukhele Make the required changes below mentioned.

@HlobisileLukhele
Copy link
Contributor Author

I have removed the arrows on the LinkedIn link username and added the Github username

"name": "Hlobisile Lukhele",
"location": "Durban, South Africa",
"bio": "I am Hlobisile, Fronted developer who is passionate about solving small businesses using my developing skills and passionate about building scalable websites",
"avatar": "https://github.com/<HlobisileLukhele>.png",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"avatar": "https://github.com/<HlobisileLukhele>.png",
"avatar": "https://github.com/HlobisileLukhele.png",

Do same with avatar.

@shyamtawli shyamtawli merged commit 02a0827 into shyamtawli:master Feb 9, 2024
3 checks passed
@shyamtawli
Copy link
Owner

@HlobisileLukhele Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants