Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update former Twitter logo #862

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Update former Twitter logo #862

merged 6 commits into from
Feb 10, 2024

Conversation

feelthatvib3
Copy link
Contributor

Description

Once again have updated former Twitter logo to the new X logo. This issue was previously resolved in the PR mentioned in Related Issues.

Related Issues

#809 (merged previously)

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 5:57am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @feelthatvib3! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@shyamtawli
Copy link
Owner

@feelthatvib3 Thanks doing it again, maybe in migration I have missed it.

Can't we use react-icons? for all there social icons?

@shyamtawli shyamtawli added the frontend Frontend related Issues label Feb 4, 2024
@feelthatvib3
Copy link
Contributor Author

feelthatvib3 commented Feb 4, 2024

@feelthatvib3 Thanks doing it again, maybe in migration I have missed it.

Can't we use react-icons? for all there social icons?

No problem, Shyam.

The main reason why I chose to stick to Font Awesome library is to keep up with the current codestyle. FontAwesomeIcon component was already used on line 52 (line 50 in my commit), so I figured we should use the same component for social icons. In addition, they look exactly the same, so no more changes were introduced apart from using other component.

If you're aiming to use react-icons throughout the code, let me know and I will update the code.

@shyamtawli
Copy link
Owner

@feelthatvib3 Go ahead and use react-icons

@feelthatvib3
Copy link
Contributor Author

@feelthatvib3 Go ahead and use react-icons

It is done.

Copy link
Owner

@shyamtawli shyamtawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feelthatvib3 There is an alignment issue with location icon and location name. Have a look into it and fix it.

It is showing
locationfix

it should display like
locationfix2

@feelthatvib3
Copy link
Contributor Author

@feelthatvib3 There is an alignment issue with location icon and location name. Have a look into it and fix it.

It is showing locationfix

it should display like locationfix2

My bad. It is so weird that I didn't notice that, thanks for pointing that out, requested changes have been applied as well as changes proposed on #865.

@shyamtawli shyamtawli merged commit 85a9a19 into shyamtawli:master Feb 10, 2024
3 checks passed
@feelthatvib3 feelthatvib3 deleted the feat/update-twitter-logo branch February 10, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested frontend Frontend related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants