-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update former Twitter logo #862
Update former Twitter logo #862
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @feelthatvib3! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
@feelthatvib3 Thanks doing it again, maybe in migration I have missed it. Can't we use react-icons? for all there social icons? |
No problem, Shyam. The main reason why I chose to stick to Font Awesome library is to keep up with the current codestyle. If you're aiming to use |
@feelthatvib3 Go ahead and use |
It is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feelthatvib3 There is an alignment issue with location icon and location name. Have a look into it and fix it.
My bad. It is so weird that I didn't notice that, thanks for pointing that out, requested changes have been applied as well as changes proposed on #865. |
Description
Once again have updated former Twitter logo to the new X logo. This issue was previously resolved in the PR mentioned in Related Issues.
Related Issues
#809 (merged previously)
Checklist
Screenshots
Note to reviewers