-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added responsiveness to sidebar #981
Conversation
* add: patrick * Update public/data/developer_assets.json Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com> --------- Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
* Added my profile (https://github.com/Erick-WG) * add: Erick-WG * Delete .vscode/settings.json * Update ProfilesList.json --------- Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
* add: Ag-neta * add: Ag-neta
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @SaranshBangar! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Resolves issue #980 |
* add: Atharv Dalal * Update ProfilesList.json
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Eman Ali Abbasi <113726637+maani31@users.noreply.github.com>
@shyamtawli sir, please look into this PR, it closes issue #980 |
Hey @SaranshBangar, could you resolve the conflicts ? Conflicting files: |
@akbatra567 Done sir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SaranshBangar,
Could you verify if the changes you've made actually made it responsive ?
This is the recording of how I see the changes you've made.
Screen.Recording.2024-05-20.at.12.32.15.AM.mov
Also Observe the size and styling difference between earlier and new design.
@akbatra567 understood sir, I will raise an updated PR by EOD |
Description
I have added a few additional media queries in the Sidebar.jsx file to resolve the issue
Related Issues
Closes issue #980
Changes Proposed
I have added a few additional media queries to fix the issue
Checklist
Screenshots
Earlier ->
Resolved ->
Note to reviewers
I am a contributor at GSSoC, please mark this PR accordingly