Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added responsiveness to sidebar #981

Closed
wants to merge 20 commits into from

Conversation

SaranshBangar
Copy link

Description

I have added a few additional media queries in the Sidebar.jsx file to resolve the issue

Related Issues

Closes issue #980

Changes Proposed

I have added a few additional media queries to fix the issue

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Earlier ->

image

Resolved ->

image

Note to reviewers

I am a contributor at GSSoC, please mark this PR accordingly

Patrick Obama and others added 14 commits April 15, 2024 20:50
* add: patrick

* Update public/data/developer_assets.json

Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>

---------

Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
* Added my profile (https://github.com/Erick-WG)

* add: Erick-WG

* Delete .vscode/settings.json

* Update ProfilesList.json

---------

Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
* add: Ag-neta

* add: Ag-neta
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 6:48pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SaranshBangar! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@SaranshBangar
Copy link
Author

Resolves issue #980

prajwalmandlik2004 and others added 5 commits May 12, 2024 23:06
* add: Atharv Dalal

* Update ProfilesList.json
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Co-authored-by: Eman Ali Abbasi <113726637+maani31@users.noreply.github.com>
@SaranshBangar
Copy link
Author

@shyamtawli sir, please look into this PR, it closes issue #980

@akbatra567
Copy link

Hey @SaranshBangar, could you resolve the conflicts ?

Conflicting files:
src/ProfilesList.json

@SaranshBangar
Copy link
Author

@akbatra567 Done sir

@akbatra567 akbatra567 added level1 GSSoC Contributions Difficulty Level GSSoC GSSoC Contributions labels May 19, 2024
@akbatra567 akbatra567 self-requested a review May 19, 2024 19:10
Copy link

@akbatra567 akbatra567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SaranshBangar,
Could you verify if the changes you've made actually made it responsive ?
This is the recording of how I see the changes you've made.

Screen.Recording.2024-05-20.at.12.32.15.AM.mov

Also Observe the size and styling difference between earlier and new design.

Earlier Design:
Screenshot 2024-05-20 at 12 34 34 AM

Current Changes:
Screenshot 2024-05-20 at 12 36 35 AM

@SaranshBangar
Copy link
Author

@akbatra567 understood sir, I will raise an updated PR by EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSoC GSSoC Contributions level1 GSSoC Contributions Difficulty Level
Projects
None yet
Development

Successfully merging this pull request may close these issues.