Skip to content

Commit

Permalink
Merge pull request #792 from SinthujanSintha/extension-improver
Browse files Browse the repository at this point in the history
Add necessary spaces and remove unnecessary spaces in syntax.
  • Loading branch information
mohanvive authored Dec 13, 2019
2 parents da332b1 + 9ae3747 commit 648141d
Showing 1 changed file with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ private static ProcessorMetaData generateProcessorMetaData(Class<?> processorCla
*/
private static StringBuilder parameterDataTypeGeneration(String parameterName,
Map<String, DataType[]> parameterDataTypeMap) {
StringBuilder parameterDataType = new StringBuilder(" <");
StringBuilder parameterDataType = new StringBuilder("<");
DataType[] parameterType = parameterDataTypeMap.get(parameterName);
for (int i = 0; i < parameterType.length; i++) {
DataType dataType = parameterType[i];
Expand All @@ -459,7 +459,7 @@ private static StringBuilder parameterDataTypeGeneration(String parameterName,
parameterDataType.append(dataType);
}
}
parameterDataType.append("> ");
parameterDataType.append(">");
return parameterDataType;
}

Expand Down Expand Up @@ -509,28 +509,28 @@ private static List<SyntaxMetaData> windowFunctionSyntaxGeneration(Extension ext
parameterClipboardSyntax.append("()");
} else {
parameterSyntax.append("(");
parameterClipboardSyntax.append("( ");
parameterClipboardSyntax.append("(");
for (int j = 0; j < parameterOverload.parameterNames().length; j++) {
String parameterName = parameterOverload.parameterNames()[j];
if (parameterName.equalsIgnoreCase(SiddhiCodeBuilderConstants.THREE_DOTS)) {
String paramName = parameterOverload.parameterNames()[j - 1];
parameterSyntax.append(parameterDataTypeGeneration(paramName, parameterDataTypeMap))
.append(SiddhiCodeBuilderConstants.THREE_DOTS);
.append(" ").append(SiddhiCodeBuilderConstants.THREE_DOTS);
parameterClipboardSyntax.append(paramName).append(SiddhiCodeBuilderConstants.THREE_DOTS);
} else {
parameterSyntax.append(
parameterDataTypeGeneration(parameterName, parameterDataTypeMap).toString());
if (j != parameterOverload.parameterNames().length - 1) {
parameterSyntax.append(parameterName).append(",");
parameterClipboardSyntax.append(parameterName).append(",");
parameterSyntax.append(" ").append(parameterName).append(", ");
parameterClipboardSyntax.append(parameterName).append(", ");
} else {
parameterSyntax.append(parameterName);
parameterSyntax.append(" ").append(parameterName);
parameterClipboardSyntax.append(parameterName);
}
}
}
parameterClipboardSyntax.append(" )");
parameterSyntax.append(" )");
parameterClipboardSyntax.append(")");
parameterSyntax.append(")");
}
SyntaxMetaData syntaxMetaData = new SyntaxMetaData(
syntax.toString() + parameterSyntax.toString(),
Expand All @@ -539,20 +539,20 @@ private static List<SyntaxMetaData> windowFunctionSyntaxGeneration(Extension ext
}
} else {
syntax.append("(");
clipBoardSyntax.append("( ");
clipBoardSyntax.append("(");
for (int i = 0; i < extension.parameters().length; i++) {
Parameter parameter = extension.parameters()[i];
syntax.append(parameterDataTypeGeneration(parameter.name(), parameterDataTypeMap));
if (i != extension.parameters().length - 1) {
syntax.append(parameter.name()).append(",");
clipBoardSyntax.append(parameter.name()).append(",");
syntax.append(" ").append(parameter.name()).append(", ");
clipBoardSyntax.append(parameter.name()).append(", ");
} else {
syntax.append(parameter.name());
syntax.append(" ").append(parameter.name());
clipBoardSyntax.append(parameter.name());
}
}
syntax.append(" )");
clipBoardSyntax.append(" )");
syntax.append(")");
clipBoardSyntax.append(")");

SyntaxMetaData syntaxMetaData = new SyntaxMetaData(syntax.toString(), clipBoardSyntax.toString());
syntaxList.add(syntaxMetaData);
Expand Down

0 comments on commit 648141d

Please sign in to comment.