Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Properties to Select and DateDropdown Components #123

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

emncnozge
Copy link
Collaborator

💡 What is the current behavior?

  • The DateDropdown component does not support specifying the starting day of the week (WeekStartIndex) or localization settings (Locale), which were introduced in the latest IX version.
  • The Select component lacks several properties, and in the latest version of IX, it is a form-ready component.
  • Select and SelectItem components lack tests.

🆕 What is the new behavior?

  • Added new properties to DateDropdown:

    • WeekStartIndex
    • Locale
  • Added new properties to Select component:

    • Name
    • Required
    • ShowTextAsTooltip
    • InfoText
    • InvalidText
    • Label
    • ValidText
    • WarningText
    • HelperText
    • DropdownWidth
    • DropdownMaxWidth
  • Added ixBlur event support to Select component

  • Added tests for Select and SelectItem

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated
  • 🧪 Unit tests were added/updated and pass (dotnet test)
  • 🏗️ Successful compilation (dotnet build, changes pushed)

👨‍💻 Help & support

Following properties are added:
name
required
showTextAsTooltip
infoText
invalidText
label
validText
warningText
helperText
dropdownWidth
dropdownMaxWidth
@emncnozge emncnozge requested a review from emregokrem March 3, 2025 11:55
@emncnozge emncnozge merged commit 9e8b802 into siemens:master Mar 3, 2025
1 check passed
@emncnozge emncnozge deleted the components-new-props branch March 4, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants