Skip to content

Commit

Permalink
bump minimum Python to 3.9
Browse files Browse the repository at this point in the history
Signed-off-by: William Woodruff <william@trailofbits.com>
  • Loading branch information
woodruffw committed Oct 8, 2024
1 parent 0b6d25e commit 9a87587
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 9 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
strategy:
matrix:
conf:
- { py: "3.8", os: "ubuntu-latest" }
- { py: "3.9", os: "ubuntu-latest" }
- { py: "3.10", os: "ubuntu-latest" }
- { py: "3.11", os: "ubuntu-latest" }
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ All versions prior to 0.9.0 are untracked.
operations, including routine local TUF repository refreshes
([#1143](https://github.com/sigstore/sigstore-python/pull/1143))

* `sigstore-python`'s minimum supported Python version is now 3.9

### Fixed

* CLI: The `sigstore verify` subcommands now always check for a matching
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ as well as performing common development tasks.

## Requirements

`sigstore`'s only development environment requirement *should* be Python 3.8
`sigstore`'s only development environment requirement *should* be Python 3.9
or newer. Development and testing is actively performed on macOS and Linux,
but Windows and other supported platforms that are supported by Python
should also work.
Expand Down Expand Up @@ -105,7 +105,7 @@ make gen-x509-testcases

### Documentation

If you're running Python 3.8 or newer, you can run the documentation build locally:
If you're running Python 3.9 or newer, you can run the documentation build locally:

```bash
make doc
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ else!

## Installation

`sigstore` requires Python 3.8 or newer, and can be installed directly via `pip`:
`sigstore` requires Python 3.9 or newer, and can be installed directly via `pip`:

```console
python -m pip install sigstore
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ classifiers = [
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -43,7 +42,7 @@ dependencies = [
"tuf ~= 5.0",
"platformdirs ~= 4.2",
]
requires-python = ">=3.8"
requires-python = ">=3.9"

[project.scripts]
sigstore = "sigstore._cli:main"
Expand Down
7 changes: 4 additions & 3 deletions test/integration/cli/test_sign.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,10 @@ def test_sign_success_default_output_bundle(capsys, sigstore, asset_integration)

assert expected_output_bundle.exists()
verifier = Verifier.staging()
with open(expected_output_bundle, "r") as bundle_file, open(
artifact, "rb"
) as input_file:
with (
open(expected_output_bundle, "r") as bundle_file,
open(artifact, "rb") as input_file,
):
bundle = Bundle.from_json(bundle_file.read())
verifier.verify_artifact(
input_=input_file.read(), bundle=bundle, policy=UnsafeNoOp()
Expand Down

0 comments on commit 9a87587

Please sign in to comment.