Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: various CQA fixes #1140

Merged
merged 2 commits into from
Sep 24, 2024
Merged

workflows: various CQA fixes #1140

merged 2 commits into from
Sep 24, 2024

Conversation

woodruffw
Copy link
Member

A bunch of small quality fixes to our workflows.

  • Adds explicit persist-credential: settings everywhere, disabling the (default) credential persistence as much as possible.
  • Moves all permissions into steps and lowers the default outer permissions where explicit.
  • Replaces a shell interpolation of github.ref with GITHUB_REF.

@woodruffw woodruffw requested a review from jku September 24, 2024 02:45
@woodruffw woodruffw self-assigned this Sep 24, 2024
jku
jku approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks

@jku jku merged commit 29905fe into main Sep 24, 2024
27 checks passed
@jku jku deleted the ww/no-persist-creds branch September 24, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku approved these changes

Assignees

@woodruffw woodruffw

Labels
chore component:cicd CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @jku