Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Use valid class for model importers #1670

Merged
merged 1 commit into from
Feb 1, 2024
Merged

FIX Use valid class for model importers #1670

merged 1 commit into from
Feb 1, 2024

Conversation

GuySartorelli
Copy link
Member

Basically the same fix as #1657, which I should have realised at the time would affect the 1.x line as well.

Issue

@GuySartorelli GuySartorelli mentioned this pull request Feb 1, 2024
Closed
2 tasks
emteknetnz
emteknetnz approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, fixes the bug in the description

Note that that the site banner module didn't appear to actually work correctly e.g. I couldn't save a start date, the banner did not actually show, though presumably that's a completely different issue

@emteknetnz emteknetnz merged commit 725a9a1 into silverstripe:1.13 Feb 1, 2024
12 checks passed
@emteknetnz emteknetnz deleted the pulls/1.13/fix-modeladmin branch February 1, 2024 21:02
@emteknetnz emteknetnz mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz