MNT Use attributes for DataProviders

silverstripe · Jan 28, 2025 · 86cac75 · 86cac75
1 parent 917ffbb
commit 86cac75
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/tests/php/ORM/DataObjectTest.php b/tests/php/ORM/DataObjectTest.php
@@ -2831,9 +2831,7 @@ public function provideExceptionForUniqueIndexViolation()
         ];
     }
 
-    /**
-     * @dataProvider provideExceptionForUniqueIndexViolation
-     */
+    #[DataProvider('provideExceptionForUniqueIndexViolation')]
     public function testExceptionForUniqueIndexViolation(array $fieldsRecordOne, array $fieldsRecordTwo, string $expectedMessage): void
     {
         DataObjectTest\UniqueIndexObject::create($fieldsRecordOne)->write();

diff --git a/tests/php/ORM/MySQLiConnectorTest.php b/tests/php/ORM/MySQLiConnectorTest.php
@@ -186,9 +186,7 @@ public function provideQueryThrowsException()
         ];
     }
 
-    /**
-     * @dataProvider provideQueryThrowsException
-     */
+    #[DataProvider('provideQueryThrowsException')]
     public function testQueryThrowsDatabaseError(int $reportMode): void
     {
         $connector = $this->getConnector();
@@ -200,9 +198,7 @@ public function testQueryThrowsDatabaseError(int $reportMode): void
         $connector->query('force an error with invalid SQL');
     }
 
-    /**
-     * @dataProvider provideQueryThrowsException
-     */
+    #[DataProvider('provideQueryThrowsException')]
     public function testQueryThrowsDuplicateEntryException(int $reportMode): void
     {
         $connector = $this->getConnector();
@@ -216,9 +212,7 @@ public function testQueryThrowsDuplicateEntryException(int $reportMode): void
         $connector->query('INSERT INTO duplicate_entry_table (Title, Name) VALUES (\'My Title\', \'My Name\');');
     }
 
-    /**
-     * @dataProvider provideQueryThrowsException
-     */
+    #[DataProvider('provideQueryThrowsException')]
     public function testPreparedQueryThrowsDatabaseError(int $reportMode): void
     {
         $connector = $this->getConnector();
@@ -229,9 +223,7 @@ public function testPreparedQueryThrowsDatabaseError(int $reportMode): void
         $connector->preparedQuery('force an error with invalid SQL', []);
     }
 
-    /**
-     * @dataProvider provideQueryThrowsException
-     */
+    #[DataProvider('provideQueryThrowsException')]
     public function testPreparedQueryThrowsDuplicateEntryException(int $reportMode): void
     {
         $connector = $this->getConnector();