Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member::getHtmlEditorConfigForCMS will make sql queries even if you don't use custom configs #11590

Closed
2 tasks done
lekoala opened this issue Jan 31, 2025 · 1 comment
Closed
2 tasks done

Comments

@lekoala
Copy link
Contributor

lekoala commented Jan 31, 2025

Module version(s) affected

5.x

Description

Member::getHtmlEditorConfigForCMS looks into $member->Groups for custom configs

But this is not necessary if you are using only the default config

How to reproduce

Have a fresh install
Check that getHtmlEditorConfigForCMS calls $this->Groups() even if its never going to find anything

Possible Solution

Add a HTMLEditorConfig::get_available_configs_map() check to avoid making queries if we are not using this feature

Additional Context

No response

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

PRs

@GuySartorelli
Copy link
Member

PR merged, will be automatically tagged by GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants