FIX Don't make queries if no custom config is set

[lekoala]

Description

Fixes unecessary queries, see issue for context

Manual testing steps

Check that no extra query is made on a fresh install

Issues

#11590

Pull request checklist

• The target branch is correct
  • See picking the right version
• All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
  • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
• The commit messages follow our commit message guidelines
• The PR follows our contribution guidelines
• Code changes follow our coding conventions
• This change is covered with tests (or tests aren't necessary for this change)
• Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
• CI is green

[GuySartorelli]

Note that this isn't really fixing a bug, but since it's a small change with very minimal risk I'll allow it to go in as a patch.

[GuySartorelli]

Why do we default to "cms" in this scenario? If there's no available config maps what would we expect returning "cms" to do here?

[lekoala]

because that's the current default if no value is found ?
this method always return something, "cms" being the default.

[michalkleiner]

Is the default defined somewhere? A config?

[lekoala]

It's hardcoded currently

silverstripe-framework/src/Security/Member.php

Line 1721 in 9d1741c

return $currentName ? $currentName : 'cms';

i kept it the way it was :-)

[GuySartorelli]

That makes sense - that part of code was hidden in the diff and I didn't think to expand to see further down.

[GuySartorelli]

LGTM, thanks for submitting this. Nice tidy enhancement.

[GuySartorelli]

If we really wanted to be fancy, we could add a filter here `$this->Groups()->filter(['HtmlEditorConfig:not' => null]) - but the benefit of that would be super low so not worth holding up merging just for that. If you're keen on that I'd be happen to merge a separate PR for that change on its own.