FIX Avoid double escaping values when printing a gridfield #11598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Feb 9, 2025
GuySartorelli
force-pushed
the
pulls/5/gridfield-print-escaping
branch
from
90627a1 to
5c2a259
Compare
2 tasks
GuySartorelli
force-pushed
the
pulls/5/gridfield-print-escaping
branch
from
5c2a259 to
b8d7202
Compare
emteknetnz
requested changes
Feb 11, 2025
GuySartorelli
force-pushed
the
pulls/5/gridfield-print-escaping
branch
from
b8d7202 to
5a5b190
Compare
emteknetnz
requested changes
Feb 11, 2025
|
See silverstripe/silverstripe-elemental#1314 (comment) - both PRs are needed. That one deals with the narrow scope of that report, where this one deals with the wider scope of reports in general. |
emteknetnz
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11596 (comment) for some more background on this PR.
The tests speak volumes here. Raw strings,
DBHTML*instances andDBTextall gave different results and had to have some special handling in the code here. If anything looks weird in the code, the reason is probably "without that, the test fails". Failures were either double escaping or new XSS vectors, both of which this PR now avoids.Issue
#11596