Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX EmailField::validate returns bool #11622

Open
wants to merge 1 commit into
base: 5.4
Choose a base branch
from

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Feb 25, 2025

Description

Just a minor phpdoc update i noticed while working with phpstan

Manual testing steps

extendValidationResult returns bool, so does this

Issues

i'm not sure an issue is required for this :)

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Just a minor phpdoc update
@GuySartorelli
Copy link
Member

The CMS 5.4 beta release process has started, so no further releases will be made on the 5 branch. Can you please update this to target the 5.4 branch?

@lekoala lekoala changed the base branch from 5 to 5.4 February 26, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants