NEW Add rule to avoid use of "new" keyword #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1/no-self
branch
3 times, most recently
from
bba1b9f to
5731848
Compare
GuySartorelli
commented
Jul 22, 2024
GuySartorelli
force-pushed
the
pulls/1/no-self
branch
from
5731848 to
be4d1d7
Compare
GuySartorelli
force-pushed
the
pulls/1/no-self
branch
from
be4d1d7 to
d52f8f4
Compare
GuySartorelli
commented
Jul 22, 2024
emteknetnz
requested changes
Jul 23, 2024
|
You said something about refactoring this in person, but I don't see a comment about it here. IIRC it was that you want the switch statement to return errors instead of returning empty arrays (i.e. reverse the conditions)? Is that right? |
|
Nah don't bother with the reversing, I think as long as there's some explanation (just a link to docs) that an empty array means "no issue" then that's good enough |
GuySartorelli
force-pushed
the
pulls/1/no-self
branch
from
d52f8f4 to
8795b5f
Compare
emteknetnz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to include tests for all the different possible usages of
selfand their contexts - let me know if there's something I'm missing and I'll add it.Issue
self#8