Fix performance issues and cleanup code #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
force-pushed
the
regression/fix-performance
branch
2 times, most recently
from
4605e9d to
91415d0
Compare
chore: revert isPredicate check deduplication Thought this affected peformance, I was wrooong chore: make codecov happy chore: eslint...
vladfrangu
force-pushed
the
regression/fix-performance
branch
from
91415d0 to
200aecf
Compare
sindresorhus
changed the title
|
Can you fix the merge conflict? |
|
Done @sindresorhus! |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #193, turns out, creating the stack trace needlessly is very, very taxing performance wise. With this PR, that is only done IF we're in a browser environment without
Error.captureStackTrace.Also, changes some string arrays to sets, as it helps keep code cleaner and removes some if checks