Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection error when the reason is empty #100

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

Sebastix
Copy link
Contributor

@Sebastix Sebastix commented Feb 7, 2025

It seems not every websocket server is responding with a reason, for example wss://nostr.wine
I found it while I was debugging some WebSocket connections, see nostrver-se/nostr-php#82 (comment) and I also reached out to the server operator: https://njump.me/nevent1qvzqqqqqqypzq0vy9tlv6h3f8u5tvcnexdcy50acec2n42ga0y9tz8m2w5k5ffpdqyv8wumn8ghj7enfd36x2u3wdehhxarj9emkjmn99uq3samnwvaz7tmrv4kxcctj9ehx7um5wgh8w6twv5hsqgrlme92sxxstf3dvha5a78mnrz9ea7eguaaw2lrvjxtu460y9fz0ykfrp9c

With this change the regex is less strict allowing an empty reason.

@coveralls
Copy link

coveralls commented Feb 10, 2025

Pull Request Test Coverage Report for Build 13249804768

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12707033125: 0.0%
Covered Lines: 1057
Relevant Lines: 1057

💛 - Coveralls

@sirn-se sirn-se merged commit 4911840 into sirn-se:v3.2-main Feb 12, 2025
8 checks passed
@sirn-se
Copy link
Owner

sirn-se commented Feb 12, 2025

Runs fine, thanks for contributing.
Will be included in next version.

@sirn-se
Copy link
Owner

sirn-se commented Feb 20, 2025

Version 3.2.3 now released, including this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants