-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection error when the reason is empty #100
Merged
sirn-se
merged 5 commits into
sirn-se:v3.2-main
from
Sebastix:connection-error-no-reason
Feb 12, 2025
Merged
Fix connection error when the reason is empty #100
sirn-se
merged 5 commits into
sirn-se:v3.2-main
from
Sebastix:connection-error-no-reason
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedilger
reviewed
Feb 7, 2025
sirn-se
reviewed
Feb 8, 2025
…ace" This reverts commit fefb3af.
Pull Request Test Coverage Report for Build 13249804768Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Runs fine, thanks for contributing. |
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems not every websocket server is responding with a reason, for example
wss://nostr.wine
I found it while I was debugging some WebSocket connections, see nostrver-se/nostr-php#82 (comment) and I also reached out to the server operator: https://njump.me/nevent1qvzqqqqqqypzq0vy9tlv6h3f8u5tvcnexdcy50acec2n42ga0y9tz8m2w5k5ffpdqyv8wumn8ghj7enfd36x2u3wdehhxarj9emkjmn99uq3samnwvaz7tmrv4kxcctj9ehx7um5wgh8w6twv5hsqgrlme92sxxstf3dvha5a78mnrz9ea7eguaaw2lrvjxtu460y9fz0ykfrp9c
With this change the regex is less strict allowing an empty reason.