Make public-facing type aliases public #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
First time using fuzzy-matcher and I noticed that
ScoreType
isn'tpub
. This is a bit of a pain if you want to store the scores anywhere, as it forces the user to use the expliciti64
type. This is an ergonomics, usability, and readability issue.Enabling or disabling the
"compact"
feature will cause compilation errors if the user is storing score results anywhere. It also makes upgrading the crate version riskier for users, as the backing type ofScoreType
orIndexType
can change.Afaik there's no downside to making these types
pub
, please correct me if I'm wrong.Builds OK.
Was not able to run tests, could not compile
termion
since I am on Windows.