Skip to content

Make public-facing type aliases public #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Grimeh
Copy link

@Grimeh Grimeh commented Nov 15, 2023

Hey there,

First time using fuzzy-matcher and I noticed that ScoreType isn't pub. This is a bit of a pain if you want to store the scores anywhere, as it forces the user to use the explicit i64 type. This is an ergonomics, usability, and readability issue.

Enabling or disabling the "compact" feature will cause compilation errors if the user is storing score results anywhere. It also makes upgrading the crate version riskier for users, as the backing type of ScoreType or IndexType can change.

Afaik there's no downside to making these types pub, please correct me if I'm wrong.

Builds OK.
Was not able to run tests, could not compile termion since I am on Windows.

@LoricAndre
Copy link

Hi, if you still need this could you please push an empty commit to trigger the CI ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants