-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor modals to wrap with ErrorBoundary and auto pass theme #182
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
155f679
to
0b52aa3
Compare
Refactor modals to be wrapped with errorBoundary and
<Modal> </Modal>
when created withcreateModal
functionautomatically pass theme to modals when created with
useThemedModal()
Add tracking how many modals are open to determine whether to render overlay or not
New:
Widget.-.Modal.Storybook.-.21.August.2024.1.mp4
Old: (The more modals open the more background/overlays would render, so it would get progressively darker)
Widget.-.Modal.Storybook.-.21.August.2024.mp4