Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modals to wrap with ErrorBoundary and auto pass theme #182

Merged
merged 10 commits into from
Aug 21, 2024

Conversation

toddkao
Copy link
Collaborator

@toddkao toddkao commented Aug 21, 2024

Refactor modals to be wrapped with errorBoundary and <Modal> </Modal> when created with createModal function

automatically pass theme to modals when created with useThemedModal()

Add tracking how many modals are open to determine whether to render overlay or not

New:

Widget.-.Modal.Storybook.-.21.August.2024.1.mp4

Old: (The more modals open the more background/overlays would render, so it would get progressively darker)

Widget.-.Modal.Storybook.-.21.August.2024.mp4

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:19pm

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 79ccd1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from FRE-930 to main August 21, 2024 22:04
@toddkao toddkao merged commit b26ed5e into main Aug 21, 2024
4 of 5 checks passed
@toddkao toddkao deleted the refactor-modals branch August 21, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants